Skip to content

feat(desktop): list descendant notes when collapsed - #489

Merged
tomymaritano merged 1 commit into
developfrom
feat/collapsed-descendants
Aug 19, 2026
Merged

feat(desktop): list descendant notes when collapsed#489
tomymaritano merged 1 commit into
developfrom
feat/collapsed-descendants

Conversation

@tomymaritano

Copy link
Copy Markdown
Collaborator

Stacked on #488.

Why

Inkdrop lists a collapsed notebook's own notes and its descendants. Ours always filtered to the selected notebook only, so collapsing the tree hid child notes.

What

  • Lift expand/collapse into notebookExpandStore (default expanded)
  • When the selected notebook is collapsed and has children, the note list uses notebookIds for that subtree
  • Expanded parents stay direct-only

Test

pnpm --filter desktop exec vitest run src/renderer/utils/__tests__/listOptionsFromNav.test.ts src/renderer/stores/__tests__/notebookExpandStore.test.ts

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tomymaritano, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7e2d983-d22d-43de-a59f-f7840c0337c2

📥 Commits

Reviewing files that changed from the base of the PR and between c369bc7 and 8a85ab0.

📒 Files selected for processing (8)
  • apps/desktop/src/renderer/components/sidebar/NotebookItem.tsx
  • apps/desktop/src/renderer/data/nowBoard.md
  • apps/desktop/src/renderer/hooks/useNavigation.ts
  • apps/desktop/src/renderer/stores/__tests__/notebookExpandStore.test.ts
  • apps/desktop/src/renderer/stores/notebookExpandStore.ts
  • apps/desktop/src/renderer/utils/__tests__/listOptionsFromNav.test.ts
  • apps/desktop/src/renderer/utils/listOptionsFromNav.ts
  • docs/NOW.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Base automatically changed from feat/workspace-view to develop August 19, 2026 02:19
Inkdrop shows a collapsed parent's notes plus its children.
Expanded notebooks stay direct-only.
@tomymaritano
tomymaritano force-pushed the feat/collapsed-descendants branch from 6eedbcf to 8a85ab0 Compare August 19, 2026 02:20
@tomymaritano
tomymaritano merged commit 5fe8eea into develop Aug 19, 2026
16 checks passed
@tomymaritano
tomymaritano deleted the feat/collapsed-descendants branch August 19, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant